-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module './lib/binding/napi-v3/argon2.node'[Bug]: #5561
Comments
First, thanks for the thorough notes! Second, sorry to hear this is happening. code-server used to work so well on Termux and the last few months haven't been great. Could you try building node-argon2 from source and seeing if that works? https://github.com/ranisalt/node-argon2#before-installing |
@jsjoeio Nope, I don't think it worked: (followed installation and rebuild steps, both failed) I believe I've been starting to have issues with installating a standalone release ever since v4.5.1 when I reset my Termux data to redo it from scratch again, before that I used to be able to install v4.0.0, v4.0.2, v4.0.5 |
Thanks for trying! Let me raise an issue upstream and see if the node-argon2 team has recommendations |
Wait one last thing, can you try |
@jsjoeio No, the command still doesn't work (I assume you are supposed to execute npm install related commands in the installation directory, specifically |
I've tried the suggestion in #5184 (comment) which is going to the
This was also one of the reasons I didn't want to bother using npm to deal with it, it has strange issues with not being able to find cached files and I'm getting tired of dealing with them (I've said this in the notes)
Additionally, I have to do a correction for the part where I said the early 4.x.x versions worked fine:
|
Thank you for the thorough explanation @RealEthanPlayzDev! I can empathize, this sounds frustrating. I am not sure myself or @code-asher have bandwidth to dive deep on this right now but I'll make it high priority and we can look at this in the upcoming or next milestone. |
@jsjoeio I understand. I'll wait for the fix, you can take your time! |
Thanks for understanding! |
It works when you download a My specs are: But yes, the errors are the same when installed via the script. |
@Sonotoki-da wow, thanks for sharing! I wonder then if we can just create a copy of that thoughts @code-asher? |
I wonder what tar.gz did the script download then 🤔 |
@jsjoeio I suppose code-server uses symlinks right? I think those links broke in the process of installation (I tried moving the extracted code-server from the comment above to |
Holy cow, that's amazing insight. We've had troubles with Termux in the past and maybe this is the clue we've been missing. Thank you so much for trying and confirming! @code-asher does this spark any ideas? |
Ah yeah if you are using something like proot I believe the
prebuild should work. Running directly on Termux should not work
though as that would require specifically compiling for Termux.
I think our Termux docs mention proot but I wonder if our
installer has some issues in that scenario like pulling the wrong
prebuild. It would be worthwhile to verify the install script's
behavior in proot with a dry run to see what is trying to do.
There are some symlinks but I am not sure how they would break.
It would make sense to see if we can reliably reproduce.
|
Sorry to bump the issue but I've had the same problem with op but mine was inside termux shell, not proot. Since links are a known issue I wanted to share my own insight to the problem. When you ignore the argon2 issue with yarn / npm and run install script it gives this output :
But since I have root access why shouldn't I use it when it's just basic links right? This is the output when you fix linking issue :
As you can see node wasn't recognized so I had to link it manually as well. I couldn't go past this I'm afraid. Let me know if these help. Thanks. Edit: Termux has mingw-w64-gcc-libs package that includes libstdc++ but installing it did not change anything whatsoever. |
Thank you for sharing all that! One idea, which we've tried in the past is switching to @node-rs/argon2 (see here: #4804 (comment)). We may investigate that again and see if using |
Yeah I would not expect the standalone |
Hey, I know this is not directly connected to argon2 issue but since I bringed up termux I might as well follow up on it. Apparently termux has a user repository with it's own code-server install script. (see here: code-server) Installing code-server was as easy as |
Good point! I think we can close this issue once we get the install script changes done in #5745. |
Doing as per termux docs worked for me. |
Is there an existing issue for this?
OS/Web Information
code-server --version
: 4.7.0 (can't use command since it can't run, but this is the version I downloaded)Steps to Reproduce
code-server --version
)Expected
code-server to run fine without any errors.
Actual
code-server crashes with the following error:
Logs
Can't run code-server at all, following error thrown:
Screenshot/Video
Does this issue happen in VS Code or GitHub Codespaces?
Are you accessing code-server over HTTPS?
Notes
nodejs-lts-gallium package
andnpm
with pacmannpm
directly doesn't really work for me, the last time I've used it, no matter what I do I couldn't upgrade code-server when a new release was released. (either saying it can't find some cached files, or it doesn't do anything and make me waste time)The text was updated successfully, but these errors were encountered: