-
Notifications
You must be signed in to change notification settings - Fork 581
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: improve coverage of cryptorand package (#377)
Check error cases in cryptorand functions, such as failures to read random data and input parameter validation.
- Loading branch information
Showing
2 changed files
with
100 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
package cryptorand_test | ||
|
||
import ( | ||
"crypto/rand" | ||
"io" | ||
"testing" | ||
"testing/iotest" | ||
|
||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/coder/coder/cryptorand" | ||
) | ||
|
||
// TestRandError checks that the code handles errors when reading from | ||
// the rand.Reader. | ||
// | ||
// This test replaces the global rand.Reader, so cannot be parallelized | ||
//nolint:paralleltest | ||
func TestRandError(t *testing.T) { | ||
var origReader = rand.Reader | ||
t.Cleanup(func() { | ||
rand.Reader = origReader | ||
}) | ||
|
||
rand.Reader = iotest.ErrReader(io.ErrShortBuffer) | ||
|
||
t.Run("Int63", func(t *testing.T) { | ||
_, err := cryptorand.Int63() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Int63 error") | ||
}) | ||
|
||
t.Run("Uint64", func(t *testing.T) { | ||
_, err := cryptorand.Uint64() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Uint64 error") | ||
}) | ||
|
||
t.Run("Int31", func(t *testing.T) { | ||
_, err := cryptorand.Int31() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Int31 error") | ||
}) | ||
|
||
t.Run("Int31n", func(t *testing.T) { | ||
_, err := cryptorand.Int31n(100) | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Int31n error") | ||
}) | ||
|
||
t.Run("Uint32", func(t *testing.T) { | ||
_, err := cryptorand.Uint32() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Uint32 error") | ||
}) | ||
|
||
t.Run("Int", func(t *testing.T) { | ||
_, err := cryptorand.Int() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Int error") | ||
}) | ||
|
||
t.Run("Intn_32bit", func(t *testing.T) { | ||
_, err := cryptorand.Intn(100) | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Intn error") | ||
}) | ||
|
||
t.Run("Intn_64bit", func(t *testing.T) { | ||
_, err := cryptorand.Intn(int(1 << 35)) | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Intn error") | ||
}) | ||
|
||
t.Run("Float64", func(t *testing.T) { | ||
_, err := cryptorand.Float64() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Float64 error") | ||
}) | ||
|
||
t.Run("Float32", func(t *testing.T) { | ||
_, err := cryptorand.Float32() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Float32 error") | ||
}) | ||
|
||
t.Run("Bool", func(t *testing.T) { | ||
_, err := cryptorand.Bool() | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected Bool error") | ||
}) | ||
|
||
t.Run("StringCharset", func(t *testing.T) { | ||
_, err := cryptorand.HexString(10) | ||
require.ErrorIs(t, err, io.ErrShortBuffer, "expected HexString error") | ||
}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters