Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve coverage of cryptorand package #377

Merged
merged 4 commits into from
Feb 28, 2022

Conversation

jawnsy
Copy link
Contributor

@jawnsy jawnsy commented Feb 28, 2022

Check error cases in cryptorand functions, such as failures to
read random data and input parameter validation.

Check error cases in cryptorand functions, such as failures to
read random data and input parameter validation.
@jawnsy jawnsy self-assigned this Feb 28, 2022
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #377 (258c918) into main (0c005ce) will increase coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   67.93%   68.38%   +0.44%     
==========================================
  Files         148      150       +2     
  Lines        8096     8274     +178     
  Branches       72       72              
==========================================
+ Hits         5500     5658     +158     
- Misses       2032     2051      +19     
- Partials      564      565       +1     
Flag Coverage Δ
unittest-go-macos-latest 66.94% <ø> (+0.76%) ⬆️
unittest-go-ubuntu-latest 67.95% <ø> (+0.77%) ⬆️
unittest-go-windows-2022 66.05% <ø> (?)
unittest-js 66.10% <ø> (ø)
Impacted Files Coverage Δ
pty/start_windows.go 51.30% <0.00%> (ø)
pty/pty_windows.go 60.31% <0.00%> (ø)
peerbroker/listen.go 84.80% <0.00%> (+2.39%) ⬆️
peer/conn.go 81.07% <0.00%> (+2.55%) ⬆️
pty/ptytest/ptytest.go 90.74% <0.00%> (+5.55%) ⬆️
cryptorand/strings.go 90.32% <0.00%> (+9.67%) ⬆️
cryptorand/numbers.go 84.07% <0.00%> (+37.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c005ce...258c918. Read the comment docs.

@jawnsy jawnsy marked this pull request as ready for review February 28, 2022 16:49
@jawnsy
Copy link
Contributor Author

jawnsy commented Feb 28, 2022

[sc-21247]

@jawnsy jawnsy merged commit 2d6804c into main Feb 28, 2022
@jawnsy jawnsy deleted the jawnsy/chore-cryptorand-err-coverage branch February 28, 2022 17:50
@jawnsy jawnsy removed their assignment Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants