fix: Allow spaces in searches (#2723)

coder · Jun 29, 2022 · baa3618 · baa3618
1 parent 889e2e6
commit baa3618
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/coderd/users_internal_test.go b/coderd/users_internal_test.go
@@ -33,6 +33,15 @@ func TestSearchUsers(t *testing.T) {
 				RbacRole: []string{},
 			},
 		},
+		{
+			Name:  "UsernameWithSpaces",
+			Query: "   user-name    ",
+			Expected: database.GetUsersParams{
+				Search:   "user-name",
+				Status:   []database.UserStatus{},
+				RbacRole: []string{},
+			},
+		},
 		{
 			Name:  "Username+Param",
 			Query: "usEr-name stAtus:actiVe",

diff --git a/coderd/workspaces_internal_test.go b/coderd/workspaces_internal_test.go
@@ -31,6 +31,14 @@ func TestSearchWorkspace(t *testing.T) {
 				Name:          "bar",
 			},
 		},
+		{
+			Name:  "Owner/NameWithSpaces",
+			Query: "     Foo/Bar     ",
+			Expected: database.GetWorkspacesParams{
+				OwnerUsername: "foo",
+				Name:          "bar",
+			},
+		},
 		{
 			Name:  "Name",
 			Query: "workspace-name",

diff --git a/site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx b/site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx
@@ -9,7 +9,7 @@ import SearchIcon from "@material-ui/icons/Search"
 import { FormikErrors, useFormik } from "formik"
 import { useState } from "react"
 import { getValidationErrorMessage } from "../../api/errors"
-import { getFormHelpers, onChangeTrimmed } from "../../util/formUtils"
+import { getFormHelpers } from "../../util/formUtils"
 import { CloseDropdown, OpenDropdown } from "../DropdownArrows/DropdownArrows"
 import { Stack } from "../Stack/Stack"
 
@@ -91,7 +91,7 @@ export const SearchBarWithFilter: React.FC<SearchBarWithFilterProps> = ({
           <TextField
             {...getFieldHelpers("query")}
             className={styles.textFieldRoot}
-            onChange={onChangeTrimmed(form)}
+            onChange={form.handleChange}
             fullWidth
             variant="outlined"
             InputProps={{