Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow spaces in searches #2723

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 29, 2022

We used to trim spaces on each character update. The backend handles spaces fine, so we don't need to trim them.

Peek 2022-06-29 11-27

@Emyrk Emyrk requested a review from a team as a code owner June 29, 2022 16:28
@Emyrk Emyrk changed the title chore: Parameter listing cmd default adding scope column fix: Allow spaces in searchs Jun 29, 2022
Copy link
Contributor

@AbhineetJain AbhineetJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UX improvement!

@Emyrk Emyrk changed the title fix: Allow spaces in searchs fix: Allow spaces in searches Jun 29, 2022
@Emyrk Emyrk merged commit baa3618 into main Jun 29, 2022
@Emyrk Emyrk deleted the stevenmasley/allow_spaces_in_search branch June 29, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants