Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove codersdk.WorkspaceAgentIP after a migration period #11819

Open
spikecurtis opened this issue Jan 25, 2024 · 0 comments
Open

Remove codersdk.WorkspaceAgentIP after a migration period #11819

spikecurtis opened this issue Jan 25, 2024 · 0 comments
Labels
chore Non-customer facing refactors, cleanup, or technical debt.

Comments

@spikecurtis
Copy link
Contributor

After removing wsconncache, current versions of Coder will no longer dial agents by the legacy IP address over tailnet. However, backlevel CLIs or Workspace Proxies might, so we keep the IP address around and assign it to agents to they are reachable.

Keeping the address presents no problem now, but we should still eventually remove it since if we ever implement agent-agent networking, or have agents contact clients over tailnet it could cause problems.
@cdr-bot cdr-bot bot added the chore Non-customer facing refactors, cleanup, or technical debt. label Jan 25, 2024
@spikecurtis spikecurtis mentioned this issue Jan 25, 2024
Merged
spikecurtis added a commit that referenced this issue Jan 30, 2024
@spikecurtis
chore: remove legacy wsconncache (#11816)
1e8a9c0 
Fixes #8218

Removes `wsconncache` and related "is legacy?" functions and API calls that were used by it.

The only leftover is that Agents still use the legacy IP, so that back level clients or workspace proxies can dial them correctly.

We should eventually remove this: #11819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Non-customer facing refactors, cleanup, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spikecurtis