Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wsconncache after migration period #8218

Closed
coadler opened this issue Jun 26, 2023 · 0 comments · Fixed by #11816
Closed

Remove wsconncache after migration period #8218

coadler opened this issue Jun 26, 2023 · 0 comments · Fixed by #11816
Assignees
@coadler
Labels
api Area: API chore Non-customer facing refactors, cleanup, or technical debt. networking Area: networking

Comments

@coadler
Copy link
Member

coadler commented Jun 26, 2023

Right now, wsconncache is left in for backwards compatibility from #8176 deprecating it. Agents used to all listen on the same Wireguard IPV6, but were transitioned to generate unique IPs on startup. Agents and CLIs must be updated before wsconncache is removed, otherwise they will become inaccessible.

Migration timeline is TBD.
@coadler coadler added the api Area: API label Jun 26, 2023
@coadler coadler self-assigned this Jun 26, 2023
@cdr-bot cdr-bot bot added the chore Non-customer facing refactors, cleanup, or technical debt. label Jun 26, 2023
@spikecurtis spikecurtis added the networking Area: networking label Sep 26, 2023
@spikecurtis spikecurtis mentioned this issue Sep 26, 2023
Closed
@spikecurtis spikecurtis mentioned this issue Jan 25, 2024
Merged
spikecurtis added a commit that referenced this issue Jan 30, 2024
@spikecurtis
chore: remove legacy wsconncache (#11816)
1e8a9c0 
Fixes #8218

Removes `wsconncache` and related "is legacy?" functions and API calls that were used by it.

The only leftover is that Agents still use the legacy IP, so that back level clients or workspace proxies can dial them correctly.

We should eventually remove this: #11819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coadler coadler

Labels
api Area: API chore Non-customer facing refactors, cleanup, or technical debt. networking Area: networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove legacy wsconncache coder/coder
2 participants
@spikecurtis @coadler