chore: Fix dependabot path after moving package.json into site #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Feb 1, 2022
jawnsy
approved these changes
Feb 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 70.41% 70.32% -0.10%
==========================================
Files 100 100
Lines 4317 4317
Branches 68 68
==========================================
- Hits 3040 3036 -4
- Misses 1029 1032 +3
- Partials 248 249 +1
Continue to review full report at Codecov.
|
|
Thanks @jawnsy @kylecarbs for reviewing! |
bryphe-coder
added a commit
that referenced
this pull request
Feb 1, 2022
…139) Unfortunately along with #133 I missed one other item in moving files to `/site` in #128 - ignoring new configuration files (and other folders) in our `jest.config.js`. This caused our coverage numbers in front-end code to dip, because files that shouldn't be included (and previously weren't included) were now being tracked for coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed in #128 - need to update the
dependabot.ymlto point to the correct package.json, which was moved from/package.json->/site/package.json