Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update coverage ignore paths after moving files into /site #139

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

bryphe-coder
Copy link
Contributor

Unfortunately along with #133 I missed one other item in moving files to /site in #128 - ignoring new configuration files (and other folders) in our jest.config.js.

This caused our coverage numbers in front-end code to dip, because files that shouldn't be included (and previously weren't included) were now being tracked for coverage.

@bryphe-coder bryphe-coder self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #139 (3959c67) into main (e2da8b9) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   70.51%   70.83%   +0.32%     
==========================================
  Files         100       98       -2     
  Lines        4317     4314       -3     
  Branches       68       68              
==========================================
+ Hits         3044     3056      +12     
+ Misses       1026     1014      -12     
+ Partials      247      244       -3     
Flag Coverage Δ
unittest-go-macos-latest 68.22% <ø> (+0.02%) ⬆️
unittest-go-ubuntu-latest 70.17% <ø> (+0.16%) ⬆️
unittest-go-windows-latest 68.34% <ø> (+0.26%) ⬆️
unittest-js 64.92% <ø> (+0.30%) ⬆️
Impacted Files Coverage Δ
site/jest.config.js
site/jest-runner.eslint.config.js
peer/conn.go 79.16% <0.00%> (+1.04%) ⬆️
provisionerd/provisionerd.go 76.75% <0.00%> (+1.08%) ⬆️
peerbroker/dial.go 80.95% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2da8b9...3959c67. Read the comment docs.

@bryphe-coder bryphe-coder merged commit 859407f into main Feb 1, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/add-codecov-ignore-files branch February 1, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants