Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add helpful tooltips for the key features #2097

Merged
merged 7 commits into from Jun 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jun 6, 2022

  • Add PageHeader component
  • Add HelpTooltip component

Closes #1640

Screen Shot 2022-06-06 at 15 11 58

Screen Shot 2022-06-06 at 15 11 45

@BrunoQuaresma BrunoQuaresma self-assigned this Jun 6, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner June 6, 2022 18:12
@BrunoQuaresma BrunoQuaresma changed the title Bq/add page header and tooltips feat: Add helpful tooltips for the key features Jun 6, 2022
@tjcran
Copy link

tjcran commented Jun 6, 2022

@BrunoQuaresma the resource tooltip looks good to me! The template tooltip, I think it's better if we remove the second sentence and just end with the word "terraform". What do you think?

Comment on lines +24 to +25
<HelpTooltipLink href="https://github.com/coder/coder/">Creating a template</HelpTooltipLink>
<HelpTooltipLink href="https://github.com/coder/coder/">Updating a template</HelpTooltipLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just one link to the templates doc for now labeled "managing templates"?

https://github.com/coder/coder/blob/main/docs/templates.md#templates

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, this one is just a sample. I'm already using this link for the templates:

 <HelpTooltipLink href="https://github.com/coder/coder/blob/main/docs/templates.md#manage-templates">
  Manage templates
</HelpTooltipLink>

site/src/components/Resources/Resources.tsx Show resolved Hide resolved
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use some Language objects for the tooltip copy. I understand the tooltip copy is still be reviewed but once that's refined, this looks great from a FE perspective!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance: There are no definitions in the UI yet for key features
4 participants