Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Page header width in the workspace page #2125

Merged
merged 1 commit into from Jun 7, 2022
Merged

fix: Page header width in the workspace page #2125

merged 1 commit into from Jun 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix bug introduced on #2097

@BrunoQuaresma BrunoQuaresma self-assigned this Jun 7, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner June 7, 2022 14:08
@BrunoQuaresma
Copy link
Collaborator Author

@Kira-Pilot what do you think about the way this calculates the page header width?

kylecarbs
kylecarbs approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) June 7, 2022 14:15
Kira-Pilot
Kira-Pilot approved these changes Jun 7, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! Eventually I would love to move away from hardcoded widths entirely (that 300px is my crime, i know) but I feel like that is a change to be handled later down the road.

@BrunoQuaresma BrunoQuaresma merged commit a4e259e into main Jun 7, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-page-header-width-on-workspace branch June 7, 2022 14:24
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@BrunoQuaresma @kylecarbs
fix: Page header width in the workspace page (#2125)
97aac8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrunoQuaresma @kylecarbs @Kira-Pilot