Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump github.com/quasilyte/go-ruleguard/dsl from 0.3.16 to 0.3.17 #280

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 14, 2022

Bumps github.com/quasilyte/go-ruleguard/dsl from 0.3.16 to 0.3.17.

Commits
  • a307c89 dsl: add experimental Do() action
  • 2e73e37 all: allow calling quasigo functions from quasigo (#378)
  • dbd4b2c ruleguard/quasigo: pass args via ValueStack (#377)
  • 6aa060f ruletuard: change group filter signature (#376)
  • cb19258 ruleguard: implement Var.Object.IsGlobal() predicate (#370)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@bryphe-coder
Copy link
Contributor

@dependabot rebase

Bumps [github.com/quasilyte/go-ruleguard/dsl](https://github.com/quasilyte/go-ruleguard) from 0.3.16 to 0.3.17.
- [Release notes](https://github.com/quasilyte/go-ruleguard/releases)
- [Commits](quasilyte/go-ruleguard@dsl/v0.3.16...dsl/v0.3.17)

---
updated-dependencies:
- dependency-name: github.com/quasilyte/go-ruleguard/dsl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/quasilyte/go-ruleguard/dsl-0.3.17 branch from 42b98c4 to c075ff1 Compare February 14, 2022 16:36
@bryphe-coder bryphe-coder self-assigned this Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #280 (c075ff1) into main (632fd80) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   68.23%   68.32%   +0.08%     
==========================================
  Files         126      126              
  Lines        6898     6898              
  Branches       69       69              
==========================================
+ Hits         4707     4713       +6     
+ Misses       1713     1708       -5     
+ Partials      478      477       -1     
Flag Coverage Δ
unittest-go-macos-latest 66.64% <ø> (+0.12%) ⬆️
unittest-go-ubuntu-latest 67.82% <ø> (+0.53%) ⬆️
unittest-go-windows-latest 66.49% <ø> (-0.28%) ⬇️
unittest-js 65.24% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 78.97% <0.00%> (-0.77%) ⬇️
provisionerd/provisionerd.go 69.74% <0.00%> (+0.39%) ⬆️
peerbroker/listen.go 84.80% <0.00%> (+2.39%) ⬆️
peerbroker/dial.go 85.71% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 632fd80...c075ff1. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affects our custom go lint rules, looks like they all pass after this patch version bump - approved

@bryphe-coder bryphe-coder merged commit c5eed90 into main Feb 14, 2022
@bryphe-coder bryphe-coder deleted the dependabot/go_modules/github.com/quasilyte/go-ruleguard/dsl-0.3.17 branch February 14, 2022 17:42
@jawnsy
Copy link
Contributor

jawnsy commented Feb 14, 2022

be careful that this version matches the version shipped with go-critic (golangci-lint includes gocritic, gocritic includes the ruleguard dsl) -- the versions have to match, otherwise you can get unusual behavior where something works running ruleguard directly but does not work when running gocritic

golangci-lint 1.44 includes go-critic 0.6.2 https://github.com/golangci/golangci-lint/blob/617470fa9e2c54dd91ab91c14e0d20030e183c20/go.mod#L27

go-critic 0.6.2 includes go-ruleguard/dsl v0.3.12 https://github.com/go-critic/go-critic/blob/f0a10a00c4ff012f328442fdd27426ca12ed03df/go.mod#L16-L17

the latest version of go-ruleguard/dsl is 0.3.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants