Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.5.2 progress percentage missing #157

Closed
inamak opened this issue Mar 25, 2018 · 19 comments
Closed

8.5.2 progress percentage missing #157

inamak opened this issue Mar 25, 2018 · 19 comments
Labels

Comments

@inamak
Copy link

inamak commented Mar 25, 2018

Hi - I am on 8.5.2 now and still only see the blue icon on copy - no percentage? Cleared browser cache but did not help. Using latest Firefox

@coderaiser
Copy link
Owner

I can not reproduce. Could you please try one of demo sites: https://cloudcmd.now.sh or http://cloudcmd.herokuapp.com

@inamak
Copy link
Author

inamak commented Mar 26, 2018

I can see the percentage on your demo site but not on my local instance. See screenshot

progress icon

I tried in latest firefox and chrome, after clearing cache in both.

@coderaiser
Copy link
Owner

There is progress option, when it set to true progress is enabled. Did you change this option? What value in your ~/.cloudcmd.json file?

@inamak
Copy link
Author

inamak commented Mar 26, 2018

Ah i finally saw progress percentage. it works on copy but not move

@inamak
Copy link
Author

inamak commented Mar 26, 2018

Weirdly i dont seem to have the ~/.cloudcmd.json file

@coderaiser
Copy link
Owner

There is no percentage on move. File will be created if you change any option.

@inamak
Copy link
Author

inamak commented Mar 26, 2018

Ah ok will you add percentage for move as well? I get an error when try to change any option - posted the error on that other issue

@coderaiser
Copy link
Owner

There is no need for progress of move operations in most cases so I do not know about it. Why do you need this? Are you often move files from different partitions and it tooks to much time?

@inamak
Copy link
Author

inamak commented Mar 28, 2018

Yes - moving files from one drive to another on my server for longer term storage. Most of the operations I do are move operations like moving files from temporary location to sorted folders. Also having to move files from drives running low on space.

@coderaiser
Copy link
Owner

OK, we need something with similar API to copymitter but using fs.rename and handling EXDEV error.

@inamak
Copy link
Author

inamak commented Mar 28, 2018

I am also not always seeing the percentage even when copying?

@coderaiser
Copy link
Owner

When you use operations like: copy, delete, pack, extract files with operations logic is loading and connecting to server with help of websockets. While websockets not connected ajax version of this operations used, it is with out progress. When websockets disconnected operations also degrades to ajax. Looks like your case is one of this two.

@inamak
Copy link
Author

inamak commented Mar 29, 2018

Interesting. Any idea why websockets isn't being used a lot of the time?

@coderaiser
Copy link
Owner

This is done for greceful enhancement, websocket connection takes time in any case. The same with greceful degradation to ajax. Also start load of Cloud Commander is much faster, because a lot logic lazy loads on first use.

@coderaiser
Copy link
Owner

Do you have any other questions or ideas for improvements?

@inamak
Copy link
Author

inamak commented Mar 29, 2018

I noticed on copy that the percentage increase can be jumpy - regularly starts jumps from 0 to 33% and then 67% instead of a more linear increase up from 0. What would cause that?

@coderaiser
Copy link
Owner

If you have 3 files, progress divedes to three parts: 33%, 67%, 100%. Looks like copymitter should be improved to count all file sizes, and then increase current position while streaming or something like that, it is a an interesting idea, but now fs.copyFile used for this purpose, and it is not provide a progress information, but can speed up the process.

@coderaiser
Copy link
Owner

coderaiser commented May 1, 2018

@inamak just improved progress copy accuracy with help of copymitter v3.0.0, you can check it by reinstalling cloudcmd with:

npm i cloudcmd -g

Landed in v9.3.2

@coderaiser
Copy link
Owner

Added ability to show progress on file move with 697df58. Landed in v9.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants