Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common #3

Merged
merged 5 commits into from Mar 20, 2012
Merged

Common #3

merged 5 commits into from Mar 20, 2012

Conversation

ghost
Copy link

@ghost ghost commented Mar 14, 2012

I've got the beginnings of a working Client class which currently uses the MemoryStorage class to keep it's data in.

SouthRibbleTech added a commit that referenced this pull request Mar 20, 2012
@SouthRibbleTech SouthRibbleTech merged commit bcc192d into SouthRibbleTech:master Mar 20, 2012
@SouthRibbleTech
Copy link
Owner

Hi Arran,

Sorry I have no got back to you before now.

Have you pushed the latest changes you discussed below to your Fork. I'd
like to take a look at them later if I get a few minutes spare.

Cheers mate speak to you soon.

Simon

On 14 March 2012 23:56, Arran Gallagher <
reply@reply.github.com

wrote:

I've got the beginnings of a working Client class which currently uses the
MemoryStorage class to keep it's data in.

You can merge this Pull Request by running:

git pull https://github.com/ArranG/BLUGMon-Hub common

Or you can view, comment on it, or merge it online at:

#3

-- Commit Summary --

  • Very early common stuff
  • More of an idea how things will work.
  • MemoryStorage created which is tested in test_storage.py
  • Filled in missing args in domain() and keys() in Storage
  • Some properties on Client now working as seen in test_client.py

-- File Changes --

A common/init.py (0)
A common/client.py (58)
A common/module.py (47)
A common/storage.py (79)
A common/task.py (45)
A common/test_client.py (21)
A common/test_storage.py (14)
A idea.py (7)
A test_common.py (18)

-- Patch Links --

https://github.com/codetastic/BLUGMon-Hub/pull/3.patch
https://github.com/codetastic/BLUGMon-Hub/pull/3.diff


Reply to this email directly or view it on GitHub:
#3

@ghost
Copy link
Author

ghost commented Mar 21, 2012

Hi Simon,

There's a 'common' branch on my forked repo with the files in the common
folder.

Arran

@ghost
Copy link
Author

ghost commented Mar 21, 2012

Looking at that quoted ('Some properties on Client now working as seen in
test_client.py') commit message, that pull request is the up-to-date. Most
recent commit being 6c76d07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant