Play behavior fix #325
Closed
Play behavior fix #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make sense to just automatically resume playback here? I think that might work better. (And as I mentioned on the other PR, commits should be signed 😃.) |
ghost
mentioned this pull request
Closed
Closed
|
Made obsolete by #424. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced what felt like a bug:
If the bot was in the middle of playing a song and everyone left, the next time you attempted to play anything after, it'd start playing but wouldn't come back to the voice channel.
The culprit was this code fragment, since it would still have songs in the player (
queueOldSize > 0) and got paused when disconnecting it would only join again when you sent a-pwithout anything.To make the experience smoother, I removed the
player.voiceConnection === nullfrom the conditional and added a message to explain it is paused.