-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - prefix sum #189
Comments
I used almost identical solutions to solve all three kata, but maybe the string vs int input is different enough? I don't know, and I have no good candidate(s) to keep. Any suggestions? |
3 asks to compute prefix sums of integers. It is a classical exercise. I am surprised that there are no other duplicates of this task. If it is not an identical duplicate of some other kata, then we should keep it. 1 is a variation of prefix sums with strings. It is not a big difference for languages like Python or JavaScript. But it can be more tricky in C or even Java (by the way its Java translation is broken). So we may keep it also. 2 can be solved in exactly the same way as 1 (with an additional number to string conversion). But it also allows simpler solutions with slices. I don't think that this kata adds anything new to the other two katas. So it can be retired. |
I think 2 allows a good variation of solutions, like slicing or dividing by 10 on the number instead. I agree with monadius said above about 1 and 3. I wouldn't consider these 3 duplicates. I'd say keep all. |
I would say to keep all 3 (3 is basic accumulate exercise and I don't consider it a duplicate). 1 and 2 have a similar idea, but I don't think they are duplicates. |
From #39
The text was updated successfully, but these errors were encountered: