-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate - median #51
Comments
I would personally keep the first kata. It has a clear and fun description, and does not include the empty-array-check. This last part might be crucial in prd environments, but in a kata it's a maintenance hell to include details for every language how to handle empty arrays (none, nan, nil, ..). I think such edge cases pollute a kata. |
Generally I agree on the empty array part. I think we don;t really need it. |
I also prefer the first kata. I think that the word 'median' should be added to the title of the first kata. |
I would also keep the first one just for the description. |
Could you guys suggest better title for the first kata? You can edit it into your posts, or post a new one, whatever you prefer. |
In python the same solution passes both katas (even the names of the functions are the same). The word |
I would suggest to keep the first one as updates are required on 3 languages of the second one, plus I translated the first one so I would not want my work to be wasted XD. I agree that empty arrays should not be tested and are difficult to maintain across multiple languages. I ported PHP and TS to the first one and updated TS to 4.2 version. As for the title, maybe we can name it as |
Median
Both kata have 6 languages, 7 kyu rank, and poor titles.
Conclusion:
The text was updated successfully, but these errors were encountered: