Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate - median #51

Closed
3 tasks done
hobovsky opened this issue Nov 20, 2021 · 7 comments
Closed
3 tasks done

Deduplicate - median #51

hobovsky opened this issue Nov 20, 2021 · 7 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Nov 20, 2021

Median

  • All Star Code Challenge #14
    • 2 unique languages out of 6 total
    • 1 issue
    • Satisfaction: 89%
    • Solves: 997
    • Created: Dec 2016
  • Median fun fun
    • 2 unique languages out of 6 total
    • 2 issues
    • Satisfaction: 92%
    • Solves: 778
    • Created: Nov 2016

Both kata have 6 languages, 7 kyu rank, and poor titles.


Conclusion:

@scoraig52
Copy link

scoraig52 commented Nov 20, 2021

I would personally keep the first kata. It has a clear and fun description, and does not include the empty-array-check. This last part might be crucial in prd environments, but in a kata it's a maintenance hell to include details for every language how to handle empty arrays (none, nan, nil, ..). I think such edge cases pollute a kata.

@hobovsky
Copy link
Contributor Author

Generally I agree on the empty array part. I think we don;t really need it.

@monadius
Copy link

I also prefer the first kata. I think that the word 'median' should be added to the title of the first kata.

@Fibonaccios
Copy link

I would also keep the first one just for the description.

@hobovsky
Copy link
Contributor Author

Could you guys suggest better title for the first kata? You can edit it into your posts, or post a new one, whatever you prefer.

@CiprianAmza
Copy link

In python the same solution passes both katas (even the names of the functions are the same). The word median should be added in the title, as the kata doesn't appear now if you search median. I assume that something like All Star Code Challenge #14 [median] should be enough?

@ejini6969
Copy link

I would suggest to keep the first one as updates are required on 3 languages of the second one, plus I translated the first one so I would not want my work to be wasted XD. I agree that empty arrays should not be tested and are difficult to maintain across multiple languages. I ported PHP and TS to the first one and updated TS to 4.2 version. As for the title, maybe we can name it as All Star Code Challenge #14 (Find the median) ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

7 participants