Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate "string subsequence" #61

Closed
1 task done
hobovsky opened this issue Jan 20, 2022 · 10 comments
Closed
1 task done

Deduplicate "string subsequence" #61

hobovsky opened this issue Jan 20, 2022 · 10 comments
Assignees
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata

Comments

@hobovsky
Copy link
Contributor

hobovsky commented Jan 20, 2022

  1. What's in a name?
  • 6kyu
  • check for random word
  • 1691 solutions, 94% satisfaction
  • 3 pending issues
  • 6 languages + 2 pending translations
  • published Oct 2019 (newer), author inactive
  1. The Fool's day
  • 6kyu
  • dumbed down when compared to 1. as it checks only for a single, predefined subsequence
  • 299 solutions, 94% satisfaction
  • No pending issues
  • 2 languages + 3 pending translations, but set of languages overlaps with the 1.
  • published Aug 2017 (older), author inactive

First question is, are these two really duplicates, as the second one uses a hardcoded subsequence and allows for solutions with a hardcoded regex?

Bonus: Beta kata Subsequence of Another, reported by FArekkusu, seems to be almost 1:1 duplicate of 1. (minus case insensitivity), and I unpublished it. Still, its author seems to strongly object. I managed to use just a slightly modified code to solve the beta and "What's in a name", so I see no real point in keeping the beta.


Conclusion:

  • Keep What's in a name?
  • Retire The Fool's day as duplicate of 1.
  • If you feel it's necessary, retire also the draft of Subsequence of Another. It's unpublished now, but there exists a concern that its author will publish it one day because they seem to not agree with the fact that their kata is a duplicate.
@hobovsky hobovsky added the discussion/deduplicate Discussion and vote what to do with duplicate kata label Jan 20, 2022
@hobovsky
Copy link
Contributor Author

hobovsky commented Jan 20, 2022

My vote: Retire 2. as an oversimplified duplicate of 1.

I think the rank for 1. is OK, the task might require some googling but overall effort fits 6 kyu IMO.
If 1. would be to stay, its description could possibly use some improvements.

@ejini6969
Copy link

I agree. Katas which involve static variables (not sure how to phrase it in a more verbose way) and expect some sort of outputs are not good compared to random inputs. So, the 2nd one should be retired plus the reason justified by hob above ~~

@FArekkusu
Copy link

This one in beta should be retired too.

@hobovsky
Copy link
Contributor Author

This one in beta should be retired too.

Unpublished. Would you have any opinions on the actual topic this, or any other deduplication issues? The more opinions we collect, the more probable we get to some conclusion allowing for actions.

Thanks!

@FArekkusu
Copy link

FArekkusu commented Jan 20, 2022

Would you have any opinions on the actual topic

Option 1 has more languages, it seems there aren't any issues with tests, and its description is clearer, so go with it, I guess.

Unpublished

Since we're supposedly getting rid of duplicates, retiring the beta ones as well seems more logical to me. Considering how the author believes his kata is not a duplicate and demands people to approve it, I doubt he'll silently comply with your decision.

@hobovsky
Copy link
Contributor Author

Considering how the author believes his kata is not a duplicate and demands people to approve it, I doubt he'll silently comply with your decision.

Yes I've noticed this, and if the kata gets republished I will ask for its retirement explicitly.
Now thinking of it, I will probably apply for its retirement too then this discussion concludes, I just do not feel it needs to be discussed here. In case of this beta, duplication is obviously clear so lets focus on the approved ones and I will ask for retirement of all dupes except one in a final conclusion.

To explain a bit, participants of deduplication threads are not meant to give some long-winded explanations or justifications, we dont need to discuss obvious cases. The deduplication issues are here to show to admins that there's a common consensus on the matter in the community and decisions are not done single-handedly. Something just as simple as "Keep X, kill Y" will suffice in majority of cases, unless the case is, for some reason, more complicated. The more people votes here, the easier it will be to convince kazk that retiring an approved kata is a result of a common understanding among users.

@Kacarott
Copy link

I agree with keeping option 1 for the reasons mentioned above, as well as having a more clear description in my opinion.

Regarding the beta, I think it should become more common practice for mods to make final decisions on whether or not betas are duplicates or not, and either resolve issues (with finality) or remove from beta. There are a lot of a lot of katas filling up beta, which are essentially pointless to solve due to them being duplicates, but will never reach a low enough satisfaction rate to retire.

@Blind4Basics
Copy link

yup, keep 1 / retire 2

@EloiseRosen
Copy link

keep 1 and retire 2 looks good 👍

@hobovsky
Copy link
Contributor Author

Created #74 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion/deduplicate Discussion and vote what to do with duplicate kata
Projects
Development

No branches or pull requests

7 participants