Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Multiset #538

Merged
merged 2 commits into from
Jun 19, 2023
Merged

Add Multiset #538

merged 2 commits into from
Jun 19, 2023

Conversation

sak-codes
Copy link
Contributor

Fixes #390

@codecov
Copy link

codecov bot commented Jun 17, 2023 •
edited
Loading

Codecov Report

Merging #538 (1205740) into main (c7b2af7) will increase coverage by 0.016%.
The diff coverage is 100.000%.

Additional details and impacted files 
@@              Coverage Diff              @@
##              main      #538       +/-   ##
=============================================
+ Coverage   98.586%   98.602%   +0.016%     
=============================================
  Files           32        33        +1     
  Lines         4173      4222       +49     
=============================================
+ Hits          4114      4163       +49     
  Misses          59        59
Impacted Files Coverage Δ
...astructs/miscellaneous_data_structures/__init__.py 100.000% <100.000%> (ø)
...astructs/miscellaneous_data_structures/multiset.py 100.000% <100.000%> (ø)
pydatastructs/trees/binary_trees.py 97.865% <100.000%> (+0.039%) ⬆️

Impacted file tree graph

czgdp1807
czgdp1807 approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the review, rest LGTM.

pydatastructs/miscellaneous_data_structures/multiset.py

class Multiset:
def __init__(self, *args):
self.counter = dict()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a "TODO: Implement dict in pydatastructs".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sak-codes sak-codes marked this pull request as ready for review June 19, 2023 05:01
czgdp1807
czgdp1807 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@czgdp1807 czgdp1807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@czgdp1807 czgdp1807 merged commit 119653a into codezonediitj:main Jun 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgdp1807 czgdp1807 czgdp1807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add multiset to pydatastructs.miscellaneous_data_structures
2 participants
@sak-codes @czgdp1807