Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-4129 Updating netty versions and blacklisting them where needed #3763

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

Kjames5269
Copy link
Contributor

(the karaf decanter bundle cassandra still uses them)
Uncomment this block and include PR # of change against 2.13.x where appropriate.
When doing so, it is reasonable to delete much of the rest of the PR description, leaving only:

  • This uncommented block with link to 2.13.x PR
  • Reviewers tagged
  • Teams tagged
  • Committers tagged
  • The link to the "Notes on Review Process"
ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT

Link to 2.13.x PR: #3741


Who is reviewing it?

@blen-desta @brjeter

@clockard
@tbatie

Select relevant component teams:

https://github.com/orgs/codice/teams

Ask 2 committers to review/merge the PR and tag them here.

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@clockard clockard self-assigned this Sep 18, 2018
@clockard
Copy link
Contributor

build now

@cxbot
Copy link

cxbot commented Sep 19, 2018

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Sep 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5273/

Build result: FAILURE

[...truncated 7.41 MB...][INFO] Finished at: 2018-09-19T04:59:50+00:00[INFO] Final Memory: 395M/1867M[INFO] ------------------------------------------------------------------------[ERROR] Failed to execute goal org.owasp:dependency-check-maven:3.1.1:check (default) on project ui: One or more exceptions occurred during dependency-check analysis: One or more exceptions occurred during dependency-check analysis[ERROR] The download was interrupted; unable to complete the update[ERROR] -> [Help 1][ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.[ERROR] Re-run Maven using the -X switch to enable full debug logging.[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionExceptionBuild step 'Invoke top-level Maven targets' marked build as failureSet build name.New build name is 'PR 3763'Taking single-use slave mesos-jenkins-d672791ffcf84a6c8578140ade0c1f29-linux-large offline.Archiving artifacts[BFA] Scanning build for known causes...[BFA] No failure causes found[BFA] Done. 12sAdding one-line test results to commit status...Setting status of 10be07f to FAILURE with url https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5273/ and message: 'JOB FAILURE: https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5273/ 457 tests run, 8 skipped, 0 failed.'Using context: Internal CI Pipeline
❌ JOB FAILURE

@Kjames5269
Copy link
Contributor Author

build now
(failure installing)

@cxbot
Copy link

cxbot commented Sep 19, 2018

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Sep 19, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5277/
✅ JOB SUCCESS

@Kjames5269
Copy link
Contributor Author

build now

@cxbot
Copy link

cxbot commented Sep 25, 2018

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Sep 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5311/
❌ JOB FAILURE

@blen-desta
Copy link
Contributor

Failure Failed to execute goal com.googlecode.maven-download-plugin:download-maven-plugin:1.4.0:wget (default) on project solr-distro: IO Error: Could not get content -> [Help 1]

build now

@cxbot
Copy link

cxbot commented Sep 25, 2018

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Sep 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5312/
❌ JOB FAILURE

@Kjames5269
Copy link
Contributor Author

build now

@cxbot
Copy link

cxbot commented Sep 25, 2018

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Sep 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5316/
❌ JOB FAILURE

…the karaf decanter bundle cassandra still uses them)
@Kjames5269
Copy link
Contributor Author

build now
(rebased after solr fix)

@cxbot
Copy link

cxbot commented Sep 25, 2018

Internal build has been scheduled, your results will be available at build completion.

@blen-desta
Copy link
Contributor

Hero'd successfully.
Verified that feature:list | grep cassandra and find . | egrep -i "netty.*(3\.9\.2|4\.\0\.33)" don't return any results

@cxbot
Copy link

cxbot commented Sep 25, 2018

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/5320/
✅ JOB SUCCESS

@clockard
Copy link
Contributor

Overrode missing sonarqube check since this doesn't change anything sonarqube looks at.

@clockard clockard merged commit f9be0a4 into codice:master Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants