Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-4472 Overriding apache.aries.proxy to fix an issue with default methods within interfaces #4353

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

Kjames5269
Copy link
Contributor

@Kjames5269 Kjames5269 commented Feb 11, 2019

ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT

Link to 2.13.x PR: #4341


Who is reviewing it?

@kcover @KalCramer

Select relevant component teams:

@codice/core-apis

Ask 2 committers to review/merge the PR and tag them here.

@clockard
@brjeter
@pklinef

How should this be tested?

Successful CI

What are the relevant tickets?

DDF-4472

Any background context you want to provide?

This would be a temporary fix until Karaf gets upgraded to 4.2.3

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@Kjames5269
Copy link
Contributor Author

build now

@cxbot
Copy link

cxbot commented Feb 11, 2019

Internal build has been scheduled, your results will be available at build completion.

@cxbot
Copy link

cxbot commented Feb 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/6201/
✅ JOB SUCCESS

@vinamartin vinamartin merged commit adab4f5 into codice:master Feb 12, 2019
Kjames5269 added a commit to Kjames5269/ddf that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants