Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDF-4472 Fix aries.proxy startup issue #4360

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Conversation

brjeter
Copy link
Contributor

@brjeter brjeter commented Feb 12, 2019

2.13.x PR: #4359

What does this PR do?

The system fails to startup without this. Caused by #4341

Who is reviewing it?

@Kjames5269 @vinamartin @Bdthomson @pklinef

How should this be tested?

Build and install DDF

Any background context you want to provide?

What are the relevant tickets?

For Jira:
DDF-4472

Screenshots

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@bdeining
Copy link
Member

build now

@cxbot
Copy link

cxbot commented Feb 12, 2019

Internal build has been scheduled, your results will be available at build completion.

@bdeining
Copy link
Member

verified install works 👍

@pklinef pklinef merged commit 836d171 into codice:master Feb 12, 2019
@cxbot
Copy link

cxbot commented Feb 12, 2019

Refer to this link for build results (access rights to CI server needed):
https://jenkins.codice.org/job/DDF-Jobs/job/pr/job/Linux/6207/
✅ JOB SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants