Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.13.x] DDF-04816 Create stopkey file in script directory #4818

Merged
merged 1 commit into from
May 14, 2019

Conversation

ahoffer
Copy link
Contributor

@ahoffer ahoffer commented May 9, 2019

What does this PR do?

Ensure that the Solr stopkey file is generated in the correct directory for *NIX systems.

Who is reviewing it?

@austinsteffes @brendan-hofmann @brjeter @tyler30clemens

Select relevant component teams:

@codice/solr

Ask 2 committers to review/merge the PR and tag them here.

@vinamartin
@brendan-hofmann
@brjeter

How should this be tested?

Can only be testing on *NIX systems.

  1. Build and unzip DDF distro
  2. Start DDF from OUTSIDE the bin directory. For example ddf-distro/bin/ddf
  3. Check that the SOLR_STOPKEY file exists in the bin directory ddf-distro/bin and NOT in the directory where the command was run.

What are the relevant tickets?

Fixes: #4816

Checklist:

  • Documentation Updated
  • Update / Add Threat Dragon models
  • Update / Add Unit Tests
  • Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

  • ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
  • ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
  • ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

@ahoffer ahoffer requested a review from stustison as a code owner May 9, 2019 22:11
@ahoffer ahoffer changed the title [2.13.x] DDF-04816 Create stopkey file in script directory DDF-04816 Create stopkey file in script directory May 9, 2019
@ahoffer ahoffer changed the title DDF-04816 Create stopkey file in script directory [2.13.x] DDF-04816 Create stopkey file in script directory May 9, 2019
@tyler30clemens
Copy link
Contributor

Does this need a fix for Windows as well?

@ahoffer
Copy link
Contributor Author

ahoffer commented May 10, 2019

@tyler30clemens No Windows changes. Windows uses batch files, not bash scripts.

@brjeter
Copy link
Contributor

brjeter commented May 14, 2019

Hero successful ✅

@brjeter brjeter merged commit 7b8755a into codice:2.13.x May 14, 2019
@brjeter brjeter added this to the 2.13.10 milestone Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants