Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin scan detect all the plugins and detect commented ones #17

Closed
grzebiel opened this issue Apr 13, 2023 · 1 comment
Closed

plugin scan detect all the plugins and detect commented ones #17

grzebiel opened this issue Apr 13, 2023 · 1 comment

Comments

@grzebiel
Copy link

It looks like plugin scan doesn't detect all the plugins, and detect ones that are commented out Take a look at mine repo you can see the plugin list there that are not detected:

[...]
  -- status line
  use 'itchyny/lightline.vim'
  -- use {"rebelot/heirline.nvim",
  --   config = function() require 'configs/heirline' end}

  -- ack/ag support
  use 'mileszs/ack.vim'

  use 'octol/vim-cpp-enhanced-highlight'
  use 'nickhutchinson/vim-cmake-syntax'
  use 'potatoesmaster/i3-vim-syntax'
[...]

image

Also worth noting, that it detects rebelot/heirline.nvim as installed, but in fact it is commented out.

@codicocodes
Copy link
Owner

codicocodes commented Apr 15, 2023

Thanks for reporting the issue!

I am not planning on addressing either of these issues at the moment, they are inherent to how the parser works, and I don't find it to be important to focus on 100% accuracy.

The way the parser works is that I index rockerboo/awesome-neovim for popular plugins, then I check the config files for mentions of those plugins.

Only plugins mentioned in awesome-neovim will be identified, I hope to increase this in the future by adding more plugin sources, but it will likely never identify all plugins with 100% accuracy because I'm not planning on spinning up a full neovim instance and run an install.

Regarding commented out plugins, I'm not interested in processing an AST to identify if the plugin is commented out or not and handle it differently. I don't think it's worth the effort for now and want to focus on more valuable features. It would also increase the complexity of the code and slow down the parser.

If you care about the correctness, I suggest removing commented out plugins from your config, and once the sync supports removing plugins they will be removed from your dotfyle page.

If you have any good ideas on increasing plugin coverage please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants