Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Rxjava for Api calls #93

Closed
aggarwalpulkit596 opened this issue May 31, 2018 · 5 comments
Closed

Adding Rxjava for Api calls #93

aggarwalpulkit596 opened this issue May 31, 2018 · 5 comments

Comments

@aggarwalpulkit596
Copy link
Contributor

Use of Rx java and retrofit for API calls and checking networking connectivity in realtime using Rx java
@abishekvashok
Copy link
Contributor

Why should we do that? We have okkayhhtp directly logged via Android studio

@aggarwalpulkit596
Copy link
Contributor Author

Okhttp can work but rxjava is better way of implementing api call as well help in making asyn task calls in background

@abishekvashok
Copy link
Contributor

You could wrap it around okkayhhtp, using retrofit seems like a bad option

@RishabhRawatAndroid
Copy link
Contributor

The Core part of Chatter app is the Api calling and if you want to change the Okhttp from the retrofit and Rxjava then it will require a lot of changes in the source code.

@aggarwalpulkit596
Copy link
Contributor Author

it will require a lot of changes but i guess it's worth it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abishekvashok @RishabhRawatAndroid @aggarwalpulkit596