Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

capture and report codiusd.service configuration parsing issues #59

Closed
mayoung6 opened this issue Jun 20, 2018 · 2 comments · Fixed by #78
Closed

capture and report codiusd.service configuration parsing issues #59

mayoung6 opened this issue Jun 20, 2018 · 2 comments · Fixed by #78
Labels
bug Something isn't working

Comments

@mayoung6
Copy link

In my codiusd.service configuration file, the "CODIUS_PUBLIC_URI" property value was missing an ending double-quote. This caused my host to be discovered as "http://local.codius.org:3000" (default). While the fix was clear, it took quite some time to see this as there were no errors or warnings. Can the configuration be validated such that any potential issues may be, at least, flagged as warnings in log?

@andywong418
Copy link
Contributor

As of pull request #39 "http://local.codius.org:3000" should not be discoverable as a peer but I agree that we should add a warning if there is no CODIUS_PUBLIC_URI set and CODIUS_DEV is not set.

@spearl spearl added the bug Something isn't working label Jun 20, 2018
@spearl
Copy link
Contributor

spearl commented Jun 26, 2018

We can't directly validate the configuration as this is interpreted by systemd not codiusd, but we can check the environment for missing or invalid values and we could also add logging to declare when we are taking a default value and not a provided one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants