Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be consistent in API returns #44

Closed
benfoley opened this issue Sep 14, 2019 · 5 comments
Closed

Be consistent in API returns #44

benfoley opened this issue Sep 14, 2019 · 5 comments

Comments

@benfoley
Copy link
Contributor

some of the end points return files, but on error we still return a json string
@benfoley
Copy link
Contributor Author

benfoley commented Sep 24, 2019 •
edited
Loading

Made consistent the success responses for those that already returned a JSON wrapped.

@benfoley
Copy link
Contributor Author

Also done all the file content responses except transcription text and elan

@benfoley
Copy link
Contributor Author

And done all existing error messages

@benfoley
Copy link
Contributor Author

Added more error messages, see #52

@benfoley
Copy link
Contributor Author

The last two in transcribe, text and elan, still returning files. But leaving it like that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benfoley