Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ListArticles] add reply type filter #178

Merged
merged 2 commits into from Jun 28, 2020
Merged

[ListArticles] add reply type filter #178

merged 2 commits into from Jun 28, 2020

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jun 28, 2020

This PR adds replyTypes filter to ListArticles so that users can list articles with specified reply types.

@MrOrz MrOrz self-assigned this Jun 28, 2020
@coveralls
Copy link

coveralls commented Jun 28, 2020 •
edited

Coverage Status

Coverage increased (+0.05%) to 86.826% when pulling d4246f2 on ListArticle-types into 3ef73e4 on master.

@MrOrz MrOrz marked this pull request as ready for review June 28, 2020 13:33
nonumpa
nonumpa approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MrOrz MrOrz merged commit 8ca66a9 into master Jun 28, 2020
@MrOrz MrOrz deleted the ListArticle-types branch June 28, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonumpa nonumpa nonumpa approved these changes

@godgunman godgunman Awaiting requested review from godgunman

@LucienLee LucienLee Awaiting requested review from LucienLee

@yanglin5689446 yanglin5689446 Awaiting requested review from yanglin5689446

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrOrz @coveralls @nonumpa