Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify command line options for fetchStatsFromGA script. #208

Merged
merged 1 commit into from Aug 16, 2020

Conversation

ztsai
Copy link
Contributor

@ztsai ztsai commented Aug 15, 2020

  • remove date validation to allow relative date pattern
  • add useContentGroup option instead of guessing from start/end dates

note that functions in util/date.js are no longer referenced in the code base, but I'd like to keep them for now.
Will remove the file if they remain unused when the project is completed.

- remove date validation to allow relative date pattern
- add useContentGroup option instead of guessing from start/end dates
@ztsai ztsai requested a review from MrOrz August 15, 2020 13:55
@ztsai ztsai added this to In progress in [Cofacts Next] Google analytics integration via automation Aug 15, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 88.158% when pulling 0fbf65b on contentGroupFlag into 800758e on master.

@ztsai ztsai moved this from In progress to Review in progress in [Cofacts Next] Google analytics integration Aug 15, 2020
[Cofacts Next] Google analytics integration automation moved this from Review in progress to Reviewer approved Aug 16, 2020
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@MrOrz MrOrz merged commit 18c2668 into master Aug 16, 2020
[Cofacts Next] Google analytics integration automation moved this from Reviewer approved to Done Aug 16, 2020
@MrOrz MrOrz deleted the contentGroupFlag branch August 16, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants