Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pseudo name & open peeps avatar gen #223

Merged
merged 2 commits into from Sep 27, 2020
Merged

pseudo name & open peeps avatar gen #223

merged 2 commits into from Sep 27, 2020

Conversation

ztsai
Copy link
Contributor

@ztsai ztsai commented Sep 17, 2020 •
edited

closes #219

@ztsai ztsai added this to In progress in [Cofacts Next] User Refactor via automation Sep 17, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 87.957% when pulling 404c5b5 on name-avatar-gen into c236081 on master.

@ztsai ztsai moved this from In progress to Review in progress in [Cofacts Next] User Refactor Sep 17, 2020
@ztsai ztsai requested a review from MrOrz September 17, 2020 07:51
[Cofacts Next] User Refactor automation moved this from Review in progress to Reviewer approved Sep 20, 2020
MrOrz
MrOrz approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation! It's fun to have these pseudonyms and avatars.

Some comments has been added regarding probability of separators & decorators.

src/util/pseudonymDict.js
'紀伯倫',
'日傑夫',
'劉德華',
'金城武',
Copy link
Member

@MrOrz MrOrz Sep 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看到這兩個我以為是自己加的，原來本來的檔案裡就有這兩個人 XDDDD
https://github.com/PlatoForum/PlatoForum/blob/master/utils/pseudonym_gen/names.csv

src/util/pseudonymDict.js Show resolved Hide resolved
@ztsai ztsai merged commit d1330bb into master Sep 27, 2020
[Cofacts Next] User Refactor automation moved this from Reviewer approved to Done Sep 27, 2020
@ztsai ztsai deleted the name-avatar-gen branch September 27, 2020 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
[Cofacts Next] User Refactor
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement name/avatar generator
3 participants
@ztsai @coveralls @MrOrz