Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor avatar related changes #247

Merged
merged 2 commits into from Feb 24, 2021
Merged

minor avatar related changes #247

merged 2 commits into from Feb 24, 2021

Conversation

ztsai
Copy link
Contributor

@ztsai ztsai commented Feb 23, 2021

  • change default image size to 100
  • add image size to facebook url
  • omit avatarData field on non-openpeeps updates, instead of wiping it

@coveralls
Copy link

coveralls commented Feb 23, 2021 •
edited

Coverage Status

Coverage increased (+0.1%) to 86.585% when pulling be97c16 on avatars into d679bc1 on master.

@ztsai ztsai requested a review from MrOrz February 23, 2021 18:20
MrOrz
MrOrz approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

src/graphql/mutations/__tests__/__snapshots__/UpdateUser.js.snap Outdated Show resolved Hide resolved
@MrOrz MrOrz merged commit bb67787 into master Feb 24, 2021
@MrOrz MrOrz deleted the avatars branch February 24, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ztsai @coveralls @MrOrz