Fix ArticleType's attachmentUrl and CreateOrUpdateArticleReplyFeedback's articleReplyUserId #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix 1: ArticleType's
attachmentUrl
field throws error whenattachmentHash
is emptyThe bug was introduced in #284 .
Querying
ArticleType
'sattachmentUrl
will triggerCannot read properties of undefined (reading 'split')
error.The root cause is that for non-image articles,
attachmentHash
is null. However, we sendnull
toMediaManager
to generate URL forattachmentUrl
field.This PR:
attachmentUrl
ifattachmentHash
is nullBugfix 2:
CreateOrUpdateArticleReplyFeedback
records wrongarticleReplyUserId
on feedback docIn the image below, the article reply feedback for article
2889dua0k41ro
and replysKR1hn0BnX5-aOa4S29I
has itsarticleReplyUserId
beingAWA_PbObyCdS-nWhukq-
; however, according to the article data, the article reply is actually created by userAVqVwjqQyrDaTqlmmp_a
.This PR
articleReplyUserId
This PR is deployed to staging on 6/25.