Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env in docker #258

Merged
merged 3 commits into from
Jun 6, 2021
Merged

Fix env in docker #258

merged 3 commits into from
Jun 6, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jun 6, 2021

Previously, docker images built by Github actions are always in English.
console.log in babel.config.js always detects en_US locale:
圖片

The root cause is that actions/checkout@v2 action will remove .env file. This PR moves .env file download to after actions/checkout@v2 and the build process can correctly pick up the env file:
圖片

@MrOrz MrOrz merged commit 767a318 into dev Jun 6, 2021
@MrOrz MrOrz deleted the fix-env-in-docker branch June 6, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants