Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow createAIReply to return null #349

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Allow createAIReply to return null #349

merged 2 commits into from
Apr 5, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Apr 4, 2023 •
edited
Loading

In cofacts/rumors-api#301 we allow CreateAIReply to return null when there are no sufficient content to create AI reply with.

We should handle this case in our handlers that calls CreateAIReply, and return original reply (with no AI reply ) in this case.

@MrOrz MrOrz self-assigned this Apr 4, 2023
@MrOrz MrOrz requested a review from nonumpa April 4, 2023 19:28
@coveralls
Copy link

coveralls commented Apr 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4615003998

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 91.683%
Totals Coverage Status
Change from base Build 4584213878: 0.03%
Covered Lines: 960
Relevant Lines: 1028
💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review April 4, 2023 19:31
@MrOrz MrOrz merged commit 277c844 into master Apr 5, 2023
@MrOrz MrOrz deleted the no-ai-reply branch April 5, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrOrz @coveralls