Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine processMedia and processImage #361

Merged
merged 18 commits into from
Sep 2, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 23, 2023

Screenshots

image image

No submission if identical image found
image

@coveralls
Copy link

coveralls commented Aug 23, 2023

Pull Request Test Coverage Report for Build 6041476975

  • 53 of 62 (85.48%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 90.491%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/webhook/handlers/processMedia.ts 42 46 91.3%
src/webhook/index.ts 8 13 61.54%
Files with Coverage Reduction New Missed Lines %
src/webhook/index.ts 1 50.0%
Totals Coverage Status
Change from base Build 5892723421: -0.3%
Covered Lines: 981
Relevant Lines: 1055

💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review August 30, 2023 19:52
@MrOrz MrOrz requested review from nonumpa and yhsiang August 30, 2023 19:52
@MrOrz MrOrz self-assigned this Aug 30, 2023
@MrOrz
Copy link
Member Author

MrOrz commented Aug 31, 2023

Update after 0831 meeting:

  • Show media similarity if available
  • More text in option if not displaying thumbnail
image
  • Don't allow sending to DB if options with >=95% media similarity exists
image

@MrOrz MrOrz merged commit 29d596e into master Sep 2, 2023
5 of 7 checks passed
@MrOrz MrOrz deleted the choosing-media-articles branch September 2, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants