Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix group message cannot read properties of undefined (reading 'timestamp') #363

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix group message cannot read properties of undefined (reading 'timestamp') #363

merged 2 commits into from
Sep 27, 2023

Conversation

nonumpa
Copy link
Member

@nonumpa nonumpa commented Sep 27, 2023

It's caused by this commit, groupHandler.addJob with a webhookEvent.

@nonumpa
fix(groupHandler): fix the bug causeed by refactor of otherfields
a6407a2 
- fix Cannot read properties of undefined (reading 'timestamp'), replace `otherfields` with `webhookEvent`
@nonumpa
fix(test): fix group test, replace otherfields with webhookEvent
7a50c98
@nonumpa nonumpa requested a review from MrOrz September 27, 2023 06:49
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6322414718

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.491%
Totals Coverage Status
Change from base Build 6058254035: 0.0%
Covered Lines: 981
Relevant Lines: 1055
💛 - Coveralls

MrOrz
MrOrz approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think we can also convert groupHandler.js and processGroupEvent.js to Typescript to ensure all field access works

@MrOrz MrOrz merged commit 62362a8 into master Sep 27, 2023
7 checks passed
@MrOrz MrOrz deleted the fix/group-message branch September 27, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nonumpa @coveralls @MrOrz