Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dot-env to manage configs #139

Merged
merged 3 commits into from
Oct 6, 2018
Merged

Use dot-env to manage configs #139

merged 3 commits into from
Oct 6, 2018

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 6, 2018

Introduces dot-env in dev environment and use docker-compose to provide env in production environment

@coveralls
Copy link

coveralls commented Oct 6, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 58.781% when pulling d3e3406 on dot-env into 798d788 on master.

@MrOrz MrOrz mentioned this pull request Oct 6, 2018
Merged
@MrOrz MrOrz requested a review from changhc October 6, 2018 16:32
@MrOrz
Remove getConfig from server.js
d3e3406 
because it's not in next.js's scope, cannot use getConfig
@MrOrz MrOrz merged commit 7b3d440 into master Oct 6, 2018
@MrOrz MrOrz deleted the dot-env branch January 12, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkbtf darkbtf Awaiting requested review from darkbtf

@godgunman godgunman Awaiting requested review from godgunman

@nonumpa nonumpa Awaiting requested review from nonumpa

@changhc changhc Awaiting requested review from changhc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrOrz @coveralls