Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Upgrade next, use next-redux-wrapper #149

Merged
merged 7 commits into from
Jan 9, 2019
Merged

Refactor: Upgrade next, use next-redux-wrapper #149

merged 7 commits into from
Jan 9, 2019

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Jan 3, 2019 •
edited
Loading

  • Upgrade from next.js 6 to next.js 7
  • Replace original app() HOC, which serves data-loading & layout purpose, with next-redux-wrapper, ordinary lifecycles, and <AppLayout> component.
    • Specifically, app()'s initFn goes to getInitialProps of each page component. bootstrapFn goes to componentDidMount of the page component.

Should have no visual change.

Known issue: FOUC becomes visible. Root cause for FOUC is unclear.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.781% when pulling 084b126 on refactor into 0168cda on master.

@MrOrz MrOrz merged commit 82affd7 into master Jan 9, 2019
@MrOrz MrOrz deleted the refactor branch January 9, 2019 05:22
MrOrz added a commit that referenced this pull request Jan 12, 2019
@MrOrz
Fix article page's article ID loading
935ccb6 
A regression made by #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucienLee LucienLee LucienLee approved these changes

@GoreStarry GoreStarry Awaiting requested review from GoreStarry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrOrz @coveralls @LucienLee @renovate-bot