New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Upgrade next, use next-redux-wrapper #149

Merged
merged 7 commits into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@MrOrz
Copy link
Member

MrOrz commented Jan 3, 2019

  • Upgrade from next.js 6 to next.js 7
  • Replace original app() HOC, which serves data-loading & layout purpose, with next-redux-wrapper, ordinary lifecycles, and <AppLayout> component.
    • Specifically, app()'s initFn goes to getInitialProps of each page component. bootstrapFn goes to componentDidMount of the page component.

Should have no visual change.

Known issue: FOUC becomes visible. Root cause for FOUC is unclear.

@MrOrz MrOrz requested review from GoreStarry and LucienLee Jan 3, 2019

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage remained the same at 58.781% when pulling 084b126 on refactor into 0168cda on master.

@MrOrz MrOrz merged commit 82affd7 into master Jan 9, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 58.781%
Details

@MrOrz MrOrz deleted the refactor branch Jan 9, 2019

MrOrz added a commit that referenced this pull request Jan 12, 2019

Fix article page's article ID loading
A regression made by #149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment