Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/new pages ui #247

Merged
merged 39 commits into from
May 4, 2020
Merged

Feature/new pages ui #247

merged 39 commits into from
May 4, 2020

Conversation

yanglin5689446
Copy link
Contributor

@yanglin5689446 yanglin5689446 commented Apr 13, 2020 •
edited
Loading

  • new article list UI
  • new replies page UI
  • search bar
  • hoax for you page
  • search result page(wip)
  • paginator

@MrOrz MrOrz self-requested a review April 14, 2020 04:45
@MrOrz
Copy link
Member

MrOrz commented Apr 14, 2020

@yanglin5689446 currently the file diff contains the changes from merged new-navbar-ui branch, which is pretty difficult to review. Would you rebase the commits?
image

MrOrz
MrOrz requested changes Apr 19, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments

components/AppLayout/GlobalSearch.js Outdated Show resolved Hide resolved
components/AppLayout/GlobalSearch.js Outdated Show resolved Hide resolved
components/TextExpansion.js Outdated Show resolved Hide resolved
components/ArticleItem.js Outdated Show resolved Hide resolved
components/ArticleItem.js Outdated Show resolved Hide resolved
components/Filters.js Outdated Show resolved Hide resolved
MrOrz
MrOrz requested changes Apr 19, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished reviewing all files! It's great to see much progress on the list pages.

It is very challenging to design the props of ArticlePageLayout. Let's move forward and see if we come up with better design in the future ;)

components/AppLayout/AppHeader.js Outdated Show resolved Hide resolved
pages/replies.js Show resolved Hide resolved
components/ReplyItem.js Outdated Show resolved Hide resolved
components/ReplyItem.js Outdated Show resolved Hide resolved
components/ReplyItem.js Outdated Show resolved Hide resolved
components/Filters.js Outdated Show resolved Hide resolved
lib/theme.js Outdated Show resolved Hide resolved
pages/hoax-for-you.js Show resolved Hide resolved
pages/hoax-for-you.js Show resolved Hide resolved
pages/search.js Outdated Show resolved Hide resolved
@yanglin5689446 yanglin5689446 mentioned this pull request Apr 30, 2020
Merged
MrOrz
MrOrz requested changes May 2, 2020
View reviewed changes
components/ReplyItem.js Show resolved Hide resolved
components/ReplyItem.js Outdated Show resolved Hide resolved
components/AppLayout/AppHeader.js Show resolved Hide resolved
components/AppLayout/AppLayout.js Outdated Show resolved Hide resolved
components/AppLayout/GlobalSearch.js Outdated Show resolved Hide resolved
components/ReplyFeedback.js Show resolved Hide resolved
components/ReplyFeedback.js Show resolved Hide resolved
pages/search.js Show resolved Hide resolved
MrOrz
MrOrz reviewed May 3, 2020
View reviewed changes
components/ReplyItem.js Outdated Show resolved Hide resolved
MrOrz
MrOrz reviewed May 3, 2020
View reviewed changes
pages/replies.js
isLink: false,
showLastReply: true,
showReplyCount: false,
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, replies page has different filter from article page.

Mockup:
image

Spec: https://g0v.hackmd.io/ZZWHWi2BTuyhkSWzAvKLAw#%E9%81%8E%E6%BF%BE%E9%81%B8%E9%A0%85%EF%BC%9A

The API for "我查核過" and reply type filtering is still on the way, but "還未有有效查核", "熱門回報" and "熱門討論" are legit ListArticle filters already (hasPositiveFeedbackArticleReply, replyRequestCount and replyCount respectively).

Considering the size of this change, I think we can handle this in future PRs, may need a ticket for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card added here: https://github.com/orgs/cofacts/projects/5#card-37494391

MrOrz
MrOrz approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's ship it to staging :shipit:

@MrOrz MrOrz merged commit cc73ad3 into dev May 4, 2020
@MrOrz MrOrz mentioned this pull request May 11, 2020
Closed
@MrOrz MrOrz deleted the feature/new-pages-ui branch May 28, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees

@yanglin5689446 yanglin5689446

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanglin5689446 @MrOrz