[Profile-01] Profile page header display #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bil4444
approved these changes
Dec 19, 2020
MrOrz
changed the title
LucienLee
reviewed
Jan 6, 2021
| variables: { id, slug }, | ||
| }); | ||
|
|
||
| const isSelf = currentUser && data?.GetUser?.id === currentUser.id; |
There was a problem hiding this comment.
Suggested change
| const isSelf = currentUser && data?.GetUser?.id === currentUser.id; | |
| const isSelf = data?.GetUser?.id === currentUser?.id; |
There was a problem hiding this comment.
Hmm if both currentUser and data is nullish (which is probably during the first render), isSelf will become true.
LucienLee
approved these changes
Jan 6, 2021
hsiao19
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements user profile page's header.
Figma: https://www.figma.com/file/zpD45j8nqDB2XfA6m2QskO/Cofacts-website?node-id=912%3A384
/user?id=xxxor/user/slug(But no one has slug yet)Screenshots
Clicking into user page
Self
(Edit button exists but its behavior is not implemented yet)
Mobile