Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor word processors #43

Merged
merged 5 commits into from
Oct 7, 2017
Merged

Refactor word processors #43

merged 5 commits into from
Oct 7, 2017

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 5, 2017 •
edited
Loading

2017-10-07 12 50 59

DON'T MERGE: Should merge after #42

  • Refactors linkify() and nl2br() so that they can be cascaded and allows React element inputs
  • Adds target="_blank" to out-going links in article & reply pages. Fixes Open new window for external links #40
  • Adds "open new window" icon at the end of target-blank links.

@MrOrz MrOrz self-assigned this Oct 5, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.3%) to 92.727% when pulling 056bb68 on refactor-word-processors into 3243405 on add-jest.

@MrOrz
[text] make sure nl2br works for more realistic cases.
4992f8f 
Remove the case that is not reasonable.
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.4%) to 92.593% when pulling 4992f8f on refactor-word-processors into 3243405 on add-jest.

@MrOrz MrOrz mentioned this pull request Oct 6, 2017
Closed
@godgunman godgunman merged commit 724f61d into add-jest Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucienLee LucienLee Awaiting requested review from LucienLee

@godgunman godgunman Awaiting requested review from godgunman

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrOrz @coveralls @godgunman