New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor <ExpandableText> #44

Merged

godgunman merged 2 commits into refactor-word-processors from refactor-expandable-text

Oct 7, 2017

Member

MrOrz commented Oct 6, 2017 •

edited

Loading

Make traverseForStrings() in util/text support BREAK
Implements truncate(), which truncates strings by length, and appends moreElem when truncation happens. This is the core of <ExpandableText>. (See util/__tests__/__snapshots__/text.js.snap)
Rewrite <ExpandableText> to leverage truncate(). Move linkify() and nl2br() to outside of <ExpandableText> implementation.

MrOrz added 2 commits

October 7, 2017 00:33


          [util/text] implements truncate()

46a63f7

traverse supportingForStrings supporting BREAK


          Decouples ExpandableText from nl2br and linkify

03c0cee

MrOrz self-assigned this

MrOrz requested review from LucienLee and godgunman

October 6, 2017 16:38

coveralls commented Oct 6, 2017

Coverage increased (+0.09%) to 92.683% when pulling 03c0cee on refactor-expandable-text into 4992f8f on refactor-word-processors.

godgunman merged commit 8061665 into refactor-word-processors

MrOrz deleted the refactor-expandable-text branch

October 8, 2017 13:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment