Fix "replied by me" filter and improve search highlighting #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using reduce is still readable in this case
bil4444
approved these changes
Aug 8, 2021
MrOrz
added a commit
that referenced
this pull request
Aug 15, 2021
- Changes from #441 are not tested because travis stopped working. - This PR updates these snapshots and fixes the repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Replied by me" filter in search page
A typo break the "replied by me" filter. Also, I forgot to implement "selected" display for "replied by me".
Both are fixed in this PR.
Fixes #370.
Reply search
Article search
Search highlighting
Previously the search string will only be highlighted if the exact string are found in the text. Space-separated search queries are considered as one string during this process, thus the search result are barely highlighted.
This PR fixes the search highlight by:
highlightfield provided in rumors-api edge fieldsArticle search
Reply search
Others
ListItem.styles.js