Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ellipsis URLs copyable #442

Merged
merged 1 commit into from
Aug 12, 2021
Merged

Make ellipsis URLs copyable #442

merged 1 commit into from
Aug 12, 2021

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Aug 8, 2021

Currently when we copy links from "References" directly, we often copy the URLs with ellipsis in the middle, thus breaks the links.

This PR adjusted how ellipsis URLs are rendered so that when user selects the text and press "copy", the full URLs are copied instead.

Technically it is replacing slice + ... with rendering the full URL + ellipsis with CSS.

Can select & copy

Notice that the "..." in the URLs are gone when pasted.
copy-paste-full-urls

Works in narrow screens

url-shrink

@MrOrz MrOrz self-assigned this Aug 8, 2021
@MrOrz MrOrz changed the base branch from master to search-enhancements August 8, 2021 17:32
Copy link
Member

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from search-enhancements to master August 12, 2021 17:06
@MrOrz MrOrz merged commit 5531367 into master Aug 12, 2021
@MrOrz MrOrz deleted the copy-able-urls branch August 12, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants