Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 360 annotation outlines #3267

Merged
merged 23 commits into from
May 19, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented May 15, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/REV-923

Description 📝

Add outline to annotations.

Before:
bg1

After:
bg2

How has this been tested? 🔍

Follow instructions in e.g. #3252 to find annotations to look at.
Try tweaking default styling for annotations in the UI.

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label May 15, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner May 15, 2023 13:22
@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #3267 (f243e88) into master (b951d5c) will increase coverage by 0.09%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #3267      +/-   ##
==========================================
+ Coverage   71.94%   72.04%   +0.09%     
==========================================
  Files         342      343       +1     
  Lines       32665    32777     +112     
  Branches     2563     2579      +16     
==========================================
+ Hits        23502    23615     +113     
+ Misses       9059     9058       -1     
  Partials      104      104              
Impacted Files Coverage Δ
viewer/jest.config.js 0.00% <0.00%> (ø)
...s/360-images/src/annotation/ImageAnnotationData.ts 0.00% <0.00%> (ø)
...360-images/src/annotation/ImageAnnotationObject.ts 79.50% <93.33%> (+5.46%) ⬆️
...ges/360-images/src/annotation/BoxAnnotationData.ts 100.00% <100.00%> (ø)
...360-images/src/annotation/PolygonAnnotationData.ts 100.00% <100.00%> (ø)
...es/360-images/src/entity/Image360RevisionEntity.ts 68.59% <100.00%> (ø)
viewer/packages/utilities/index.ts 100.00% <100.00%> (ø)
.../packages/utilities/src/three/VariableWidthLine.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions
Copy link

There were failures in the visual tests workflow.
Image diffs for visual tests can be downloaded as an artifact here.

Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I think it's a very big improvement in visual quality! A few comments but nothing critical.

viewer/package.json Outdated Show resolved Hide resolved
viewer/packages/utilities/src/three/ThickLine.ts Outdated Show resolved Hide resolved
viewer/reveal.api.md Outdated Show resolved Hide resolved
viewer/packages/utilities/src/three/ThickLine.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I think it's a very big improvement in visual quality! A few comments but nothing critical.

Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good yet again! Only minor comments.

viewer/jest.config.js Show resolved Hide resolved
@haakonflatval-cognite haakonflatval-cognite merged commit 696a0fa into master May 19, 2023
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/360-annotation-outlines branch May 19, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants