-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 360 annotation outlines #3267
feat: 360 annotation outlines #3267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3267 +/- ##
==========================================
+ Coverage 71.94% 72.04% +0.09%
==========================================
Files 342 343 +1
Lines 32665 32777 +112
Branches 2563 2579 +16
==========================================
+ Hits 23502 23615 +113
+ Misses 9059 9058 -1
Partials 104 104
|
There were failures in the visual tests workflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I think it's a very big improvement in visual quality! A few comments but nothing critical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I think it's a very big improvement in visual quality! A few comments but nothing critical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good yet again! Only minor comments.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/REV-923
Description 📝
Add outline to annotations.
Before:
After:
How has this been tested? 🔍
Follow instructions in e.g. #3252 to find annotations to look at.
Try tweaking default styling for annotations in the UI.
Test instructions ℹ️
Checklist ☑️