-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coil does not upscale resources #76
Comments
@r4phab This is currently intended behaviour. Coil avoids loading images at a larger size than necessary to conserve memory. This behaviour is also fairly core to how Coil handles the dynamic sampling crossfade effect. If you need to upscale an image, I'd recommend creating a |
Quick update on this issue. I probably won't have time to address this for |
Thank you @colinrtwhite for your prompt response and your explanations |
This is now fixed in master. To get the fix asap you can depend on See #183 for more info on the implementation, but TLDR Coil will now ensure the loaded image's dimensions are as requested for custom targets and |
@colinrtwhite just to know, when are you planning to release 0.9.0 ? Just to know if I need to use some workarounds or wait a little bit |
@bishiboosh I'd estimate in the next 1-2 weeks. Definitely before December 25th. |
Describe the bug
When I download a resource from URL and its size is smaller than the requested size in the
GetRequestBuilder
, result is not upscaled. On the contrary, when I set a smaller size inside myGetRequestBuilder
, the resource is correctly downscaled.To Reproduce
Download this image using
Coil.get(url) { size(256, 256) }
Expected behavior
I would expect to have a resulting drawable of 256x256 instead of the 24x24 provided
Library version
0.6.1
The text was updated successfully, but these errors were encountered: