Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CI failed ⚠️ #839

Closed
github-actions bot opened this issue May 9, 2023 · 3 comments
Closed

⚠️ CI failed ⚠️ #839

github-actions bot opened this issue May 9, 2023 · 3 comments

Comments

@github-actions
Copy link

github-actions bot commented May 9, 2023

Workflow Run URL

@j-bennet
Copy link
Contributor

j-bennet commented May 9, 2023

Exception:  Regressions detected 9: 
runtime = 'coiled-latest-py3.9', name = 'test_join_big[1-tasks]', category = 'benchmarks', last_three_duration [s] = (661.3068561553955, 661.3068561553955, 664.7528762817383), duration_threshold [s] = 645.971376454088 

runtime = 'coiled-latest-py3.9', name = 'test_memory_efficient', category = 'benchmarks', last_three_duration [s] = (14.592434644699097, 14.592434644699097, 14.425075054168701), duration_threshold [s] = 14.400530576705933 

runtime = 'coiled-latest-py3.9', name = 'test_q8[0.5 GB (csv)-p2p]', category = 'benchmarks', last_three_duration [s] = (23.257978677749634, 23.257978677749634, 22.042306423187256), duration_threshold [s] = 21.1036319050846 

runtime = 'coiled-latest-py3.9', name = 'test_q8[0.5 GB (csv)-tasks]', category = 'benchmarks', last_three_duration [s] = (23.347721576690674, 23.347721576690674, 21.66010046005249), duration_threshold [s] = 20.842681142124796 

runtime = 'coiled-latest-py3.9', name = 'test_q8[0.5 GB (parquet)-p2p]', category = 'benchmarks', last_three_duration [s] = (38.65501809120178, 38.65501809120178, 37.90650749206543), duration_threshold [s] = 28.452760344775673 

runtime = 'coiled-latest-py3.9', name = 'test_q8[0.5 GB (parquet)-tasks]', category = 'benchmarks', last_three_duration [s] = (38.17823791503906, 38.17823791503906, 37.13248825073242), duration_threshold [s] = 27.552817533184218 

runtime = 'coiled-latest-py3.9', name = 'test_q8[5 GB (parquet)-p2p]', category = 'benchmarks', last_three_duration [s] = (190.76829409599304, 190.76829409599304, 179.65282678604126), duration_threshold [s] = 168.1402059770922 

runtime = 'coiled-latest-py3.9', name = 'test_q8[5 GB (parquet)-tasks]', category = 'benchmarks', last_three_duration [s] = (193.05822157859802, 193.05822157859802, 179.8635790348053), duration_threshold [s] = 179.30978843531042 

runtime = 'coiled-latest-py3.9', name = 'test_q9[0.5 GB (parquet)-tasks]', category = 'benchmarks', last_three_duration [s] = (4.537719488143921, 4.537719488143921, 4.642199754714966), duration_threshold [s] = 4.443351241496266 

This doesn't seem valid, in charts only 2 last points were higher than median, not 3.

test_memory_efficient:

image

test_join_big[1-tasks]:

image

test_q8[0.5 GB (csv)-p2p]:

image

@j-bennet j-bennet closed this as completed May 9, 2023
@j-bennet
Copy link
Contributor

j-bennet commented May 9, 2023

For some reason, in the table of runtimes, the last 2 records are a dupe:

image

From https://benchmarks.coiled.io/details/coiled-latest-py3.9-benchmarks-test_h2o-test_q8[0.5%20GB%20(csv)-p2p].html, same cluster, same everything. What's up with that? How did these get into benchmarks db?

image

cc @crusaderky

@crusaderky
Copy link
Contributor

Weird. Looks like something caused combine-dbs to pick up the same run twice
https://github.com/coiled/benchmarks/blob/3062113a0a33e69c049379817ac7de49ef76004f/.github/workflows/tests.yml#L162C11-L165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants