fix to compile with -Werror=format-security

[svigerske]

Issue created by migration from Trac.

Original creator: @mlubin

Original creation time: 2013-08-06 03:44:57

Version:

I'm working on updating the Debian package for coinutils, and they now strongly encourage compiling with -Werror=format-security. This short patch is required to make this work.

--- a/CoinUtils/src/CoinMessageHandler.cpp
+++ b/CoinUtils/src/CoinMessageHandler.cpp
`@``@` -820,7 +820,7 `@``@`
          sprintf(messageOut_,g_format_,doublevalue);
          if (next != format_+2) {
            messageOut_+=strlen(messageOut_);
-           sprintf(messageOut_,format_+2);
+           strcpy(messageOut_,format_+2);
          }
        }
        messageOut_+=strlen(messageOut_);

[svigerske]

Current code says

          if (next != format_ + 2) {
            messageOut_ += strlen(messageOut_);
            sprintf(messageOut_, "%s", format_ + 2);
          }

This should also have suppressed this warning/error. But I agree that using strcpy would be better.