Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Improve the error handling. #44

Closed
kitsunde opened this issue Jun 6, 2017 · 1 comment · Fixed by #86
Closed

Improve the error handling. #44

kitsunde opened this issue Jun 6, 2017 · 1 comment · Fixed by #86

Comments

@kitsunde
Copy link

kitsunde commented Jun 6, 2017

When coinbase gives a 502 and presumably any error, it throws a TypeError because it's tries to decode the returned html as json.

This whole library basically assumes coinbase is always returning the right thing, there's no error handling here at all: https://github.com/coinbase/coinbase-python/blob/master/coinbase/wallet/model.py#L301-L315

At a minimum it should return the actual connection issue, these are not type issues.

@sds sds added the enhancement label Mar 8, 2018
@sds
Copy link
Contributor

sds commented Mar 8, 2018

Hey @kitsunde, thanks for the suggestion.

Would happily accept a PR implementing improved error handling!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

2 participants