Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefunded Accounts #117

Merged
merged 5 commits into from
Aug 21, 2020
Merged

Prefunded Accounts #117

merged 5 commits into from
Aug 21, 2020

Conversation

juliankoh
Copy link
Contributor

@juliankoh juliankoh commented Aug 21, 2020

Motivation

  • Upgrade to latest rosetta-sdk-go
  • Add logic in tester/construction to get balances of all addresses

Solution

Open questions

@coveralls
Copy link

coveralls commented Aug 21, 2020

Pull Request Test Coverage Report for Build 4034

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.969%

Totals Coverage Status
Change from base Build 3943: 0.0%
Covered Lines: 599
Relevant Lines: 799

💛 - Coveralls

@@ -94,13 +94,13 @@ func (h *BroadcastStorageHelper) BroadcastTransaction(
ctx context.Context,
networkTransaction string,
) (*types.TransactionIdentifier, error) {
transactionIdentifier, _, err := h.fetcher.ConstructionSubmit(
transactionIdentifier, _, fetchErr := h.fetcher.ConstructionSubmit(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating these!

Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@juliankoh juliankoh merged commit 070e261 into master Aug 21, 2020
@juliankoh juliankoh deleted the julian/prefund branch August 21, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants